Remove the import wizard's scene-to-map link step - #151
Merged
Merged
Conversation
Chronicle maps open in Foundry as journal pages that appear on connect, so pairing scenes with maps only set an unused scene flag. The wizard drops the Maps step (7 steps now), its plan items and strings, and the import runner drops the link-map case and the createMapping wrapper it alone used. Fixes #129 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WURTwLzEdwXRLKXnnQtFCS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Key Maker · project thread
Fixes #129
Security implication: none. Removes a step and its unused write path.
Consumer-verified: n/a. No Chronicle wire surface is added; the removed path posted a
chronicle_type: "map"sync mapping thatMapSync.onSyncMappingalready ignored.Foundry compatibility: n/a. Off-DOM only:
node --checkon the changed scripts, plus the template/step-index test below.Mockup: Sign-offs card
module129-wizard-maps-step, signed "Yes, remove it".What this changes
Before: the import wizard had 8 steps. Step 7, Maps, paired each Foundry scene with a Chronicle map. Picking a map set a
mapIdflag on the scene and posted a sync mapping. Nothing reads either one: Chronicle maps open in Foundry as journal pages in the "Chronicle Maps" folder, created on connect (MapSync.onInitialSync).After: the wizard has 7 steps, with Review last. The Maps panel, its plan items, change listeners and strings are gone. In the import runner, the
link-mapcase goes, and so does thecreateMappingwrapper that only it called. The scan step still counts scenes in the world, and scenes linked by older versions keep their harmless flag.Why
Issue #129. The step suggested a feature that no longer exists. Key Maker signed the before/after card on the Sign-offs page.
Test plan
node --test tools/test-*.mjs: 1272 tests, 1271 pass, 1 skipped, 0 fail (after bringing main in). Addstools/test-import-wizard-steps.mjs(3 tests). It checks that the step list isconnect … calendar, review, that template panels are numbered 0..6 to match, and that nolink-map/mapLinkPlanremains.node --check scripts/import-wizard.mjs scripts/sync-manager.mjsTenet self-check
Generated by Claude Code