Skip to content

Lock down actions#10

Merged
wkz merged 2 commits intomainfrom
lock-down-actions
Apr 13, 2023
Merged

Lock down actions#10
wkz merged 2 commits intomainfrom
lock-down-actions

Conversation

@troglobit
Copy link
Copy Markdown
Contributor

Since complete builds currently take over 2h to complete, we cannot start the existing build workflow on any event.

This PR locks down our current GitHub action in two ways:

  • Only allow (or attempt) upload of latest build from main repo and main branch
  • Start Bob the Builder automatically on manual start (workflow_dispatch) or when a PR to main has been approved

Separate workflows for validating YANG models and running unit tests to be added later.

Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
Signed-off-by: Joachim Wiberg <troglobit@gmail.com>
@troglobit troglobit requested review from rical and wkz April 13, 2023 08:49
Copy link
Copy Markdown
Contributor

@rical rical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wkz wkz merged commit e9757ac into main Apr 13, 2023
@troglobit troglobit deleted the lock-down-actions branch April 13, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants