Pin latest Wrangler deploy tooling for worker CI#758
Conversation
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThree GitHub Actions deploy workflows replaced Cloudflare's wrangler-action@v3 with direct npm-executed wrangler CLI invocation. Wrangler development dependencies in three service packages were updated to ^4.80.0. Documentation updated to recommend workspace-installed wrangler via npm exec. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
Summary
cloudflare/wrangler-actiondependency from all 3 worker deploy workflowsnpm exec wrangler -- ...wrangler@4.80.0and document that CI should use the repo-installed CLI instead of runner-provided toolingFixes #757
Investigation
24045455017configuration.observability cannot be modified via PATCH. Use rollout target_configuration.observability or top-level observability instead4.75.0Testing
npm exec --workspace call-kent-audio-worker wrangler -- --version->4.80.0npm exec --workspace oauth wrangler -- --version->4.80.0npm exec --workspace search-worker wrangler -- --version->4.80.0npm run lint --workspace call-kent-audio-worker && npm run typecheck --workspace call-kent-audio-worker && npm run test --workspace call-kent-audio-workernpm run lint --workspace oauth && npm run typecheck --workspace oauthnpm run lint --workspace search-worker && npm run typecheck --workspace search-worker && npm run test --workspace search-workernpx prettier --check .github/workflows/deploy-call-kent-audio-worker.yml .github/workflows/deploy-oauth-worker.yml .github/workflows/deploy-search-worker.yml docs/agents/project-context.mdnpm exec wrangler -- --versionfrom:services/call-kent-audio-workerservices/oauthservices/search-workernpm exec --workspace call-kent-audio-worker wrangler -- deploy --dry-runreached Wrangler4.80.0and then stopped because this Cursor VM does not have a Docker-compatible CLI installed (docker: command not found), so I could not run the local container build to completion hereNotes
services/search-worker/src/search-results.test.ts; they are unrelated to this change and did not block typecheck/testsSummary by CodeRabbit
Chores
Documentation