Skip to content

use jest.isMockFunction - #116

Merged
kentcdodds merged 1 commit into
kentcdodds:mainfrom
p10ns11y:patch-1
Nov 2, 2020
Merged

use jest.isMockFunction#116
kentcdodds merged 1 commit into
kentcdodds:mainfrom
p10ns11y:patch-1

Conversation

@p10ns11y

@p10ns11y p10ns11y commented Nov 2, 2020

Copy link
Copy Markdown
Contributor

Using jest.isMockFunction(setTimeout) over setTimeout._isMockFunction (https://jestjs.io/docs/en/jest-object#jestismockfunctionfn)

@codecov

codecov Bot commented Nov 2, 2020

Copy link
Copy Markdown

Codecov Report

Merging #116 into main will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   69.96%   69.96%           
=======================================
  Files          27       27           
  Lines         293      293           
  Branches       28       28           
=======================================
  Hits          205      205           
  Misses         80       80           
  Partials        8        8           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c12ee28...f2fd327. Read the comment docs.

@p10ns11y

p10ns11y commented Nov 2, 2020

Copy link
Copy Markdown
Contributor Author

Build failures not seem to be related to the changes

@kentcdodds kentcdodds left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is better 👍 Thanks!

@kentcdodds
kentcdodds merged commit a30b82e into kentcdodds:main Nov 2, 2020
@kentcdodds

Copy link
Copy Markdown
Owner

@all-contributors please add @p10ns11y for code

@allcontributors

Copy link
Copy Markdown
Contributor

@kentcdodds

I've put up a pull request to add @p10ns11y! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants