Custom DST#2
Open
kennytm wants to merge 27 commits into
Open
Conversation
Centril
reviewed
Nov 12, 2018
Centril
left a comment
Centril
left a comment
There was a problem hiding this comment.
Some typos mostly; (there are plenty left I think so you'll want to proof read this...)
Comments were made as I read them so you might have addressed some bits in later parts of the RFC, for example re. const fn.
| ```rust ,ignore | ||
| trait X: Aligned | ||
| where | ||
| const(align_of::<Self>() == 2) |
There was a problem hiding this comment.
trait T<U: Align<2>> {
type V: PartialEq<U> + Align<2>,
};)
Owner
Author
There was a problem hiding this comment.
🤔 having Align<2> could imply a type can simultaneously implement Align<1> + Align<2> + Align<4> + ...
There was a problem hiding this comment.
Oooooops!
trait T<U: Align<Val = 2>> {
type V: PartialEq<U> + Align<Val = 2>,
}We already have associated consts so we can probably do it today.
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
Co-Authored-By: kennytm <kennytm@gmail.com>
kennytm
pushed a commit
that referenced
this pull request
Feb 2, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendered
(This is a completed and trimmed down version of https://github.com/kennytm/rfcs/tree/dyn-type/text/0000-dyn-type excluding stuff already handled by rust-lang#2580 and rust-lang#2310, and removing all placement-new stuff.)