Add cornerRadius value on UnderlineFocusView#120
Merged
kazuhiro4949 merged 2 commits intokazuhiro4949:masterfrom Apr 22, 2020
devmjun:feature/add_cornerRadius_value_on_underlineFocusView
Merged
Add cornerRadius value on UnderlineFocusView#120kazuhiro4949 merged 2 commits intokazuhiro4949:masterfrom devmjun:feature/add_cornerRadius_value_on_underlineFocusView
kazuhiro4949 merged 2 commits intokazuhiro4949:masterfrom
devmjun:feature/add_cornerRadius_value_on_underlineFocusView
Conversation
Owner
|
@devmjun Thanks! Could you remove IDEWorkspaceChecks.plist? It's a configuration for your local environment. |
Contributor
Author
|
@kazuhiro4949 I removed it🙇♂️ |
kazuhiro4949
approved these changes
Apr 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I add values that are cornerRadius and masksToBounds. because of developing UI such as the attached image.
Please review myPR. thank you :)