fix(deps): update socket.io to version 2.0.3#2821
fix(deps): update socket.io to version 2.0.3#2821kevinsalter wants to merge 1 commit intokarma-runner:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I signed it! |
|
CLAs look good, thanks! |
|
We require browser support down to IE 7, can you confirm that this is still given with this new socket.io version? otherwise I don't think we can easily upgrade |
|
@dignifiedquire I realize this may not be your decision but would you be able to change your support requirements? Looking at a bunch of browser usage statistics, IE 7 doesn't even register anymore as a used browser. Also, even Microsoft themselves don't support it as well as a few versions above it. |
@dignifiedquire as far as I can see, socket.io still supports IE6+7. Their test suite/CI has passing automated tests for both these browsers: Would be great to get this merged and published! Thanks @kevinsalter for putting this PR together, I'm currently using your fork until this gets merged 👍 |
|
Any update on this? The current version of Socket.io being used, 1.7.4, relies on debug@2.3.3 which has a known ReDos vulnerability. |
|
The version of socket.io being used also relies on |
johnjbarton
left a comment
There was a problem hiding this comment.
I assume that the CI tests cover the cases important to users so we need to have those pass.
This is a duplicate of @kevinsalter PR #2821. His PR fails on appveyor and we can't figure out how to change the repo config to fix the build there or how to retry that build. So let's just try from scratch. Fixes issue #2777
This is a duplicate of @kevinsalter PR karma-runner#2821. I am re-sending after appveyor fixup. (We don't seem to have the ability to retry appveyor builds). Fixes karma-runner#2777
|
Thanks @kevinsalter, to get around being unable to re-build in appveyor, I stole your thunder in #2880 |
|
@johnjbarton all good, happy to see this go out 😄 |

Fixes issue #2777