Fixed zz doesn't center the due to wrapped line#76
Merged
karb94 merged 7 commits intokarb94:masterfrom Jan 15, 2023
chomosuke:fix-zz
Merged
Fixed zz doesn't center the due to wrapped line#76karb94 merged 7 commits intokarb94:masterfrom chomosuke:fix-zz
karb94 merged 7 commits intokarb94:masterfrom
chomosuke:fix-zz
Conversation
Owner
|
Thank you @chomosuke! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there's wrapped line, sometimes scroll_one_line scroll more than one graphical line, this causes relative_line to be recorded wrong.
This means that if you're dealing with files with a lot of very long lines, typing zz scrolls more than it should. Sometimes no matter how many times you type zz you never get the cursor to center, it simply oscillate as it overshoots every time.
simplescreenrecorder-2023-01-07_21.11.19-converted.mp4
This PR fixes that:
simplescreenrecorder-2023-01-07_21.12.36-converted.mp4