Repository navigation
feat(v2): make audio history player keyboard-accessible - #185
Open
RahulHarihar wants to merge 1 commit into
Open
RahulHarihar wants to merge 1 commit into
RahulHarihar wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #184
In
desktop/src/components/AudioPlayer.tsx, the waveform seeker declaredrole="slider"with ARIA min/max/now attributes, but lacked focusability and keyboard event handlers.This PR completes the W3C APG Slider keyboard contract for the audio player:
tabIndex={peaks ? 0 : -1}with a subtle focus indicator (focus-visible:ring-2 focus-visible:ring-accent/50), consistent with the existingdisabled={!peaks}guard on the Play button.onKeyDownhandler:←/→: seek backward / forward by 5 secondsHome/End: jump to 0:00 / track endSpace/Enter: toggle play / pausearia-valuetextannouncing formatted time (e.g.,0:15 of 1:20) viaformatClock.Tested On
npm run typecheckpassed cleanlynpm test -- --runpassed cleanly