Repository navigation
Fix/format model size and tests - #149
RahulHarihar wants to merge 3 commits into
Conversation
|
The one-line fix is right and I'd like to take it: Keep these tests: the Please drop or rewrite the rest. Several assert that the function equals a copy of its own body, for instance One real gap while you're in there: Small thing: Thanks for the write-up in #148, it was unusually clear. |
|
Thanks for the review and guidance @karansinghgit! I've updated the tests to drop the tautological assertions, added the test for |
Summary
mb >= 1000) informatModelSizeby updating it to binary (mb >= 1024), matching themb / 1024divisor andformatBytesconvention.formatModelSizeboundary values (999,1000,1023,1024,1536,2048).plural(0, 1, 2) and edge cases forcountWords.formatCompactwith literal assertions beside number formatters.formatDaywith literal values against a frozennow, including the previously untested branch for dates over a week old in the current year.Fixes #148
Tested On
npm run typecheck,npm test,npx vite build)