Repository navigation
Conversation
Isolate scheduling condition ownership by node pool and migrate legacy status ownership without replacing unrelated controller fields. Fence stale verdicts with version checks and bounded conflict retries. Preserve newer queued updates and merge only the current pool status into scheduler snapshots. Add envtest coverage for schema upgrades, legacy cleanup, concurrent writers, and scheduling state handoff. Document the required CRD rollout and the incompatibility with older assigners that infer condition recency from list position. Validation: relevant unit and envtest suites, targeted race tests, repository-wide go vet, and local lint passed. Docker-based make validate could not complete because the Docker daemon was unavailable. Signed-off-by: gaoyk19 <gaoyk19@163.com>
1 of 4 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace full PodGroup
UpdateStatuscalls with server-side apply so scheduler writes preserve other node pools' conditions and controller-owned resource statistics.Each node pool uses a stable field manager. The writer migrates legacy ownership, checks the CRD merge schema, and uses version preconditions with bounded retries to reject stale verdicts while handling concurrent updates.
The change also preserves newer queued updates and merges only the current pool's status into scheduler snapshots.
Related Issues
Fixes #2612.
Checklist
make changelog.Breaking Changes
Older assigners that read the last list element as the latest condition are incompatible. Consumers must select the condition with the highest numeric
TransitionID.Upgrade consumers and the PodGroup CRD before enabling this writer, and stop old scheduler status writers during the transition. No legacy-write mode is provided.
Migration details are documented in
docs/developer/designs/podgroup-status-ssa/README.md.Additional Notes
Depends on kai-scheduler/api#36. Keep this PR as a draft until that change is released and
go.modis updated.Validation passed:
go vet.make validatecould not complete its Docker lint step because the local Docker daemon was unavailable.