Skip to content

comments #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apeksharma wants to merge 1 commit into
base: main
Choose a base branch
from
Open

comments #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions .github/workflows/java-app-ecr-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:

ecr_registry:
type: string
default: "454518750364.dkr.ecr.ap-south-1.amazonaws.com"
default: "454518750364.dkr.ecr.ap-south-1.amazonaws.com" # add comment mentioning which aws account

java_version:
type: string
Expand All @@ -20,12 +20,12 @@ on:
# ───── Tagging ─────
tag_prefix:
type: string
default: "rc" # auto-overridden to "hotfix" for hotfix-* branches
default: "rc" # auto-overridden to "hotfix" for hotfix-* branches # Remove, should be computed.

# ─────────────────────────────────────────
# GLOBAL ENV
# ─────────────────────────────────────────
env:
env: # add the env variables we discussed https://jupitermoney.atlassian.net/wiki/spaces/~7120200844f5ce0a8d4d9296aca72b692dcdc7/pages/4102684673/RFC+Zero-Config+CI?focusedCommentId=4118216985
ECR_REGISTRY: ${{ inputs.ecr_registry }}

# Security / Trivy
Expand All @@ -43,6 +43,8 @@ env:
SONAR_TOKEN: ${{ secrets.SONARQUBE_TOKEN }}
GITHUB_EVENT: ${{ toJson(github.event) }}

# add the github token to push to metadata repo

# ─────────────────────────────────────────
# JOBS
# ─────────────────────────────────────────
Expand Down Expand Up @@ -87,11 +89,15 @@ jobs:
- name: Generate Service Metadata
run: ./gradlew generateServiceMetadata

# add `./gradlew validate` task

# Skipped on pull_request events — PR validation is handled by java-app-pr-check.yml.
- name: Run Tests
if: github.event_name == 'push'
run: ./gradlew test


# should we consider doing 'build' separately first?

- name: Parse Service Metadata
id: parse
run: |
Expand Down