Skip to content

fix: do not add a label for the exporter name - #1058

Merged
bennyz merged 1 commit into
jumpstarter-dev:mainfrom
bennyz:exporter-name-label
Sep 2, 2026
Merged

fix: do not add a label for the exporter name#1058
bennyz merged 1 commit into
jumpstarter-dev:mainfrom
bennyz:exporter-name-label

Conversation

@bennyz

@bennyz bennyz commented Sep 2, 2026

Copy link
Copy Markdown
Member

we should just use the name, no need to send a label that will be persisted to the k8s resource

we should just use the name, no need to send a label
that will be persisted to the k8s resource

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 0330b637-b109-4e60-a74a-ac29a0d9487a

📥 Commits

Reviewing files that changed from the base of the PR and between da74a63 and f28c675.

📒 Files selected for processing (3)
  • python/packages/jumpstarter/jumpstarter/config/exporter.py
  • python/packages/jumpstarter/jumpstarter/exporter/exporter.py
  • python/packages/jumpstarter/jumpstarter/exporter/exporter_test.py

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The exporter name is now a dedicated Exporter field. Configuration passes the name through this field, logging uses it, and tests no longer store it in labels.

Changes

Exporter name migration

Layer / File(s) Summary
Exporter name field and log context
python/packages/jumpstarter/jumpstarter/exporter/exporter.py
Exporter adds exporter_name and uses it in server, lease, and standalone log contexts.
Exporter construction and test fixtures
python/packages/jumpstarter/jumpstarter/config/exporter.py, python/packages/jumpstarter/jumpstarter/exporter/exporter_test.py
Exporter construction and test setup pass the name through exporter_name instead of the labels dictionary.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to f28c6

This change stops persisting the exporter name as a Kubernetes label while retaining it for logging; authentication, registration, endpoint selection, and device access remain unchanged. No actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: mangelajo

Poem

A rabbit hops through logs so bright
The exporter name is set just right
No label hides the name away
Tests follow the cleaner way
Config and context now agree

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description directly explains that the exporter name should not be persisted as a Kubernetes label. It matches the changeset and PR objective.
Title check ✅ Passed The title clearly summarizes the main change: stop adding a label for the exporter name.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 10 functions across 3 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bennyz
bennyz added this pull request to the merge queue Sep 2, 2026
Merged via the queue into jumpstarter-dev:main with commit 600a2fd Sep 2, 2026
28 checks passed
@bennyz
bennyz deleted the exporter-name-label branch September 2, 2026 12:11
RoddieKieley added a commit to RoddieKieley/jumpstarter that referenced this pull request Sep 2, 2026
…1058

jumpstarter-dev#1058 stopped sending jumpstarter.dev/name on Register, so identity=self.name
was "unknown" and the hub rejected the stream.

Co-authored-by: Cursor <cursoragent@cursor.com>
RoddieKieley added a commit to RoddieKieley/jumpstarter that referenced this pull request Sep 2, 2026
…1058

jumpstarter-dev#1058 stopped sending jumpstarter.dev/name on Register, so identity=self.name
was "unknown" and the hub rejected the stream. Recapture the Phase 3 demo
with that identity fix applied.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants