fix: do not add a label for the exporter name - #1058
Conversation
we should just use the name, no need to send a label that will be persisted to the k8s resource Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe exporter name is now a dedicated ChangesExporter name migration
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change stops persisting the exporter name as a Kubernetes label while retaining it for logging; authentication, registration, endpoint selection, and device access remain unchanged. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…1058 jumpstarter-dev#1058 stopped sending jumpstarter.dev/name on Register, so identity=self.name was "unknown" and the hub rejected the stream. Co-authored-by: Cursor <cursoragent@cursor.com>
…1058 jumpstarter-dev#1058 stopped sending jumpstarter.dev/name on Register, so identity=self.name was "unknown" and the hub rejected the stream. Recapture the Phase 3 demo with that identity fix applied. Co-authored-by: Cursor <cursoragent@cursor.com>
we should just use the name, no need to send a label that will be persisted to the k8s resource