Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #281 +/- ##
==========================================
- Coverage 89.20% 89.01% -0.20%
==========================================
Files 15 16 +1
Lines 1973 2057 +84
==========================================
+ Hits 1760 1831 +71
- Misses 213 226 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
blegat
reviewed
Feb 24, 2025
blegat
reviewed
Feb 24, 2025
* fix conic error * use jump psd problem * [docs] update to Documenter@1 (#286) * [docs] update to Documenter@1 * Update * update * format * Pass attributes through Objective.FunctionConversionBridge (#287) * Pass attributes through Objective.FunctionConversionBridge * Fix * add test * fix tol * fix test * add reverse test --------- Co-authored-by: joaquimg <joaquimdgarcia@gmail.com> * bump POI * cleanup --------- Co-authored-by: Oscar Dowson <odow@users.noreply.github.com> Co-authored-by: Benoît Legat <benoit.legat@gmail.com> Co-authored-by: joaquimg <joaquimdgarcia@gmail.com>
* prepare more tests * sketch * temp examples * remove printing * remove printing * remove duplicatie def * move definition * format * format * simplify conic model * force nlp on nlp tests * fix param tests * cleanup parameter usage * remove code * cleanup usage of parameters * format * add temp dep * format * add temp dep * fix PSDSquare * temp fix for tests * format
joaquimg
commented
Jul 21, 2025
Comment on lines
+610
to
613
| # TODO check ci.value's | ||
| idx = model.cache.dual_mapping[ci.value] | ||
| return model.forw_grad_cache.dual_Δs[idx] | ||
| catch |
Member
Author
There was a problem hiding this comment.
@andrewrosemberg , this way of getting the map does not seem to match perfectly with the one below
Collaborator
There was a problem hiding this comment.
My logic was:
dual_Δsis indexed by NLP model constraint index, so we need to go from MOI to NLP usingdual_mapping- In the one below
Δpis indexed my NLP Parameter index, so we need to go from MOI variable index to NLP parameter index, thus the use ofvar2param
This was referenced Aug 15, 2025
Open
Merged
* integrate new POI * remove test * rm adhoc pkg add * fix docs * add POI test and docs * rm test_solve_conflict * format * add parameter in cone test * add back name constraint vect * Update Project.toml --------- Co-authored-by: Joaquim <joaquimdgarcia@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #271