Skip to content

Package consistency cleanup#66

Merged
blakeembrey merged 1 commit intomasterfrom
be/prepare
Apr 15, 2026
Merged

Package consistency cleanup#66
blakeembrey merged 1 commit intomasterfrom
be/prepare

Conversation

@blakeembrey
Copy link
Copy Markdown
Member

Fix license-url, remove lint script, remove lower-case from README (it seems it never did this but it was documented, added tests to confirm behavior doesn't change in the future).

@blakeembrey blakeembrey requested a review from a team April 15, 2026 19:01
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e42461c) to head (73d06db).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #66   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          120       120           
  Branches        39        38    -1     
=========================================
  Hits           120       120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread README.md
Format an object into a `Content-Type` header. This will return a string of the content type for the given object with the following properties (examples are shown that produce the string `'image/svg+xml; charset=utf-8'`):

- `type`: The media type (will be lower-cased). Example: `'image/svg+xml'`.
- `type`: The media type. Example: `'image/svg+xml'`.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current 1.x says it'll be lower cased but it doesn't actually:

content-type/index.js

Lines 66 to 97 in 8f44754

function format (obj) {
if (!obj || typeof obj !== 'object') {
throw new TypeError('argument obj is required')
}
var parameters = obj.parameters
var type = obj.type
if (!type || !TYPE_REGEXP.test(type)) {
throw new TypeError('invalid type')
}
var string = type
// append parameters
if (parameters && typeof parameters === 'object') {
var param
var params = Object.keys(parameters).sort()
for (var i = 0; i < params.length; i++) {
param = params[i]
if (!TOKEN_REGEXP.test(param)) {
throw new TypeError('invalid parameter name')
}
string += '; ' + param + '=' + qstring(parameters[param])
}
}
return string
}

Copy link
Copy Markdown
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blakeembrey blakeembrey merged commit 1a5a33d into master Apr 15, 2026
8 checks passed
@blakeembrey blakeembrey deleted the be/prepare branch April 15, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants