Repository navigation
Support for "Hybrid" semi-/colon SGR parameters - #327
Merged
Merged
Conversation
Apply accumulated integer SGR parameters before each following colon color. Preserve valid reset/color ordering through the C-backed propagation and clipping APIs, with native and Python regression coverage. Assisted-by: OpenAI Codex
# Conflicts: # libwcwidth/src/sgr.c
Merging this PR will not alter performance1 warning
Comparing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #327 +/- ##
==========================================
+ Coverage 90.07% 91.46% +1.39%
==========================================
Files 44 44
Lines 6447 6388 -59
Branches 1810 1806 -4
==========================================
+ Hits 5807 5843 +36
+ Misses 241 164 -77
+ Partials 399 381 -18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
Author
|
More coverage will be provided in an upcoming branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supersedes #321. I studied kitty and xterm parsing about this small possible deviation from ECMA-48/ITU T.416/etc. standards, and those changes have been simplified (WCWIDTH_SGR_MAX_PARAMS was removed, malloc/realloc/free removed), while also supporting "hybrid" sequences found to be supported in at least xterm and kitty, and it brings coverage of the changed code up to 100%
Note that #321 was likely created by AI Analysis, that these are probably Unlikely sequences, but, because I discovered code in xterm and kitty that attempts to support them, it is presumed that some misbehaving TUI program or library somewhere must have drove them into the more complex accommodation.