Skip to content

fix(provider): Method.Random[Key] behaviour#226

Merged
RealShadowNova merged 4 commits into
mainfrom
fix/random-behaviour
Jul 1, 2023
Merged

fix(provider): Method.Random[Key] behaviour#226
RealShadowNova merged 4 commits into
mainfrom
fix/random-behaviour

Conversation

@WilsontheWolf

@WilsontheWolf WilsontheWolf commented Jun 30, 2023

Copy link
Copy Markdown
Member

This changes the randomKey and random error behaviour as discussed in discord.

Commit Body

BREAKING CHANGE: `Payload.Random#duplicates` has been renamed to `#unique`.
BREAKING CHANGE: `Payload.RandomKey#duplicates` has been renamed to `#unique`.

@codecov

codecov Bot commented Jun 30, 2023

Copy link
Copy Markdown

Codecov Report

Merging #226 (9e6051d) into main (6efe3ae) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #226      +/-   ##
==========================================
+ Coverage   92.97%   93.00%   +0.02%     
==========================================
  Files          29       29              
  Lines        2435     2443       +8     
  Branches      103      103              
==========================================
+ Hits         2264     2272       +8     
  Misses        168      168              
  Partials        3        3              
Impacted Files Coverage Δ
...ckages/provider/src/lib/structures/JoshProvider.ts 99.31% <100.00%> (+<0.01%) ⬆️
packages/provider/src/lib/types/Payload.ts 100.00% <100.00%> (ø)

@RealShadowNova RealShadowNova changed the title fix: random and randomKey errors fix(provider): Method.Random[Key] behaviour Jun 30, 2023
@RealShadowNova RealShadowNova merged commit e7030b9 into main Jul 1, 2023
@RealShadowNova RealShadowNova deleted the fix/random-behaviour branch July 1, 2023 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants