Skip to content

Symfony compatibility: remove wrongly overridden "load()" method but preserve the logic - #241

Merged
jonnnnyw merged 1 commit into
jonnnnyw:masterfrom
BR0kEN-:symfony-compatibility
Apr 3, 2018
Merged

Symfony compatibility: remove wrongly overridden "load()" method but preserve the logic#241
jonnnnyw merged 1 commit into
jonnnnyw:masterfrom
BR0kEN-:symfony-compatibility

Conversation

@BR0kEN-

@BR0kEN- BR0kEN- commented Mar 7, 2018

Copy link
Copy Markdown
Contributor

This PR is aimed to fix the next critical issue:

In ServiceContainer.php line 20:

  [Symfony\Component\Debug\Exception\ContextErrorException]
  Warning: Declaration of JonnyW\PhantomJs\DependencyInjection\ServiceContainer::load() should be compatible with Symfony\Component\DependencyInjection\Container::load($file)

By the meaning it duplicates #235 but has no extra changes.

@jonnnnyw
jonnnnyw merged commit 9fa2959 into jonnnnyw:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants