Skip to content

Update ServiceContainer.php - #217

Closed
buzz8year wants to merge 1 commit into
jonnnnyw:masterfrom
buzz8year:master
Closed

Update ServiceContainer.php#217
buzz8year wants to merge 1 commit into
jonnnnyw:masterfrom
buzz8year:master

Conversation

@buzz8year

Copy link
Copy Markdown

Proposing to ducktape the following issue:
PHP Warning: Declaration of JonnyW\PhantomJs\DependencyInjection\ServiceContainer::load() should be compatible with Symfony\Component\DependencyInjection\Container::load($file)

by public function load($file = null)

@leyxian

leyxian commented Dec 2, 2017

Copy link
Copy Markdown

In ServiceContainer.php line 20:

Declaration of JonnyW\PhantomJs\DependencyInjection\ServiceContainer::load(
) should be compatible with Symfony\Component\DependencyInjection\Container
::load($file)

@buzz8year

Copy link
Copy Markdown
Author

good

@buzz8year

buzz8year commented Jan 16, 2018

Copy link
Copy Markdown
Author

repo's relevant file code does not seem to be fixed so far - reopening request...

moved to #232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants