Skip to content

chore: add Makefile for build/install/run workflow#140

Merged
johnno1962 merged 1 commit into
johnno1962:2.0_overhaulfrom
maatheusgois-dd:maatheusgois-dd/makefile-2.0-overhaul
Apr 20, 2026
Merged

chore: add Makefile for build/install/run workflow#140
johnno1962 merged 1 commit into
johnno1962:2.0_overhaulfrom
maatheusgois-dd:maatheusgois-dd/makefile-2.0-overhaul

Conversation

@maatheusgois-dd

Copy link
Copy Markdown
Contributor

Summary

Adds a top-level Makefile to streamline local development of the macOS app on the 2.0_overhaul branch.

Targets:

  • build-app – builds InjectionNext.app (Debug) via xcodebuild with ad-hoc signing.
  • run – builds, installs to /Applications, and launches the app.
  • open / move-app – install the built app to /Applications and open it.
  • kill – kill any running InjectionNext process (used before build/install to avoid code-sign/launch races).
  • sync – pull latest and update submodules (DLKit, InjectionLite).
  • clean – remove derived data.

No source code changes. Purely a developer convenience file.

Test Plan

  • make build-app builds successfully against App/InjectionNext.xcodeproj.
  • make run launches the freshly built InjectionNext.app.
  • make kill terminates the running app cleanly.
  • make sync pulls + updates submodules.

Made with Cursor

@maatheusgois-dd maatheusgois-dd marked this pull request as ready for review April 20, 2026 11:59
@johnno1962

Copy link
Copy Markdown
Owner

Would it be ok to put the Makefile in the "App" directory?

@maatheusgois-dd

Copy link
Copy Markdown
Contributor Author

Done — pushed a split layout:

  • App/Makefile holds the real recipes (build-app, run, open, move-app, kill, clean), colocated with InjectionNext.xcodeproj as you suggested.
  • Root Makefile is a thin delegator ($(MAKE) -C App $@) so make build-app from the repo root still works for the unix-convention muscle memory.
  • sync (git pull + submodule update) stays root-only, since it's a repo-level operation.

make help from root now shows everything including sync; make -C App help shows just the app-local targets.

If you'd rather have a single file (no delegator) at either location, happy to flatten — just say the word.

@johnno1962

johnno1962 commented Apr 20, 2026

Copy link
Copy Markdown
Owner

The word :) The Makefile only relates to the App no?

Adds a Makefile next to InjectionNext.xcodeproj (App/Makefile) with
all dev-loop targets. Run from App/ (or `make -C App <target>` from
the repo root).

Targets:
- build-app — builds InjectionNext.app (Debug) via xcodebuild with
  ad-hoc signing.
- run — build, install to /Applications, launch.
- open / move-app — install + launch.
- kill — terminate any running InjectionNext (used before build/
  install to avoid code-sign/launch races).
- sync — git pull + submodule update (DLKit, InjectionLite).
- clean — remove derived data.

No source changes.
@maatheusgois-dd maatheusgois-dd force-pushed the maatheusgois-dd/makefile-2.0-overhaul branch from 32f9b3a to af1e234 Compare April 20, 2026 18:30
@maatheusgois-dd

Copy link
Copy Markdown
Contributor Author

Flattened — single App/Makefile now, root Makefile deleted. sync moved into App/Makefile (git still walks up so git pull + git submodule update from App/ just works).

Usage:

  • cd App && make build-app (or run / open / kill / sync / clean)
  • make -C App build-app from the repo root

Single commit, 64-line diff — down from the delegator variant. Ready for another look.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a developer-focused Makefile under App/ to streamline building, installing, and running the InjectionNext macOS app from the command line.

Changes:

  • Introduces build-app target that builds InjectionNext.app via xcodebuild into a local derived data directory.
  • Adds install/launch workflow targets (move-app, open, run) plus convenience targets (kill, sync, clean, help).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread App/Makefile
@echo "==> Opening $(APP_PATH)..."
@open /Applications/InjectionNext.app

run: build-app open
Comment thread App/Makefile
-quiet
@echo "==> Build complete: $(APP_PATH)"

move-app: build-app kill
Comment thread App/Makefile
Comment on lines +51 to +52
@echo "==> Opening $(APP_PATH)..."
@open /Applications/InjectionNext.app
@johnno1962

Copy link
Copy Markdown
Owner

Man, these AI reviews really are know-it-alls.

@johnno1962 johnno1962 merged commit 2c7d846 into johnno1962:2.0_overhaul Apr 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants