Conversation
Author
|
I am not sure that this code is 100% correct. Occasionally, when calling I experimented with My workaround is to use something similar to promiseTimeout() to reject and then retry the parse. FWIW I am currently testing in an electron environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The jsdoc-parse version is quite old and has some vulnerabilities in its dependencies. The author of jsdoc-parse, after bumping the version to 2.x, recommends using the
getTemplateData()function from his package jsdoc-to-markdown instead of the lower level jsdocParse(). This patch replaces 'jsdocParse()' with a call tojsdoc2md.getTemplateData().