feat(agents): add Kimi Code CLI support - #248
Conversation
Signed-off-by: Liang Hu <lh3057@columbia.edu>
johannesjo
left a comment
There was a problem hiding this comment.
Requesting changes for one merge-blocking coordinator-path issue.
electron/mcp/agent-args.ts:62 — Coordinator-created Kimi children never load their per-task MCP config.
Coordinator.createTask writes each child config to /tmp/parallel-code-subtask-.json natively or the coordinator .parallel-code/subtask-.json in Docker, then relies on buildMcpLaunchArgs to pass that path. This new Kimi branch returns an empty argument list. Kimi Code 0.31.1 discovers only its user mcp.json, project-root .mcp.json, and cwd/.kimi-code/mcp.json (published loader source), so neither generated child path is read. The child therefore starts without the parallel-code MCP server and cannot call land_self or signal_done, breaking the default Kimi coordinator-child flow in both native and Docker modes.
Please write or merge the unique child config into an auto-discovered child-worktree location while preserving token isolation and cleanup/restoration, and add coordinator child-creation coverage for Kimi. The new store test exercises top-level coordinator restoration only; it does not cover Coordinator.createTask.
Signed-off-by: Liang Hu <lh3057@columbia.edu>
|
Addressed the coordinator-child blocker in
Validation:
|
Summary
kimiagent with current resume and permission-bypass flags.kimi-codeauth/config directory--mcp-configargument and cover native, Docker, and coordinator launch behaviorFixes #109.
Validation
npx vitest run electron/ipc/agents.test.ts electron/mcp/agent-args.test.ts electron/ipc/pty.test.ts src/lib/agent-args.test.ts src/store/tasks.test.tsnpm run checknpm run check:staticnpm testnpm run test:security-rulesnpm run build:frontendnpm run build:remotenpm run build:mcp