Skip to content

Logging / Interactive cli / Docker / Refactorings#27

Open
rugpanov wants to merge 43 commits into
joebowbeer:masterfrom
rugpanov:contribute
Open

Logging / Interactive cli / Docker / Refactorings#27
rugpanov wants to merge 43 commits into
joebowbeer:masterfrom
rugpanov:contribute

Conversation

@rugpanov

Copy link
Copy Markdown

Hi there. Thank you for such a useful tool:

-- logging --

  • added logger instead of console.log
  • improve logging

-- interactive cli --

  • added inquirer library to support interactive cli, when part of required parameters are absent + it allows to hide password

-- refactorings --

  • many-many refactoring. hope you love it
  • error handling for various cases

-- docker wrapping --
-- merge and refactored @albertstill/regsync --

  • add latest only, latest majors and repository override args

@joebowbeer joebowbeer left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look like useful contributions. Thanks!

Are you interested in maintaining this at @rugpanov/regsync?

I wrote this for a specific migration and I don't have much need for it now, so it is not easy for me to maintain it.

I can attach a very permissive (MIT) license to the code in this repo.

Comment thread README.md Outdated
Comment thread package-lock.json Outdated
@joebowbeer joebowbeer self-requested a review February 28, 2022 02:16
* Publish to docker registry
* Fix typos in package-lock
@rugpanov

Copy link
Copy Markdown
Author

Yes, sure.

My intention was to help as many people as possible. I decided to make this PR because your repo is already one of the most popular solutions for npm registry migration.

But if it is inconvenient to you, I can maintain the repo under my own profile, surely.

Comment thread src/filters.ts Outdated
Comment thread src/utils.ts Outdated
Comment thread src/cli.ts Outdated
Comment thread src/util.test.ts Outdated
Comment thread src/settings.ts Outdated
Comment thread src/utils.ts Outdated
Comment thread src/utils.ts Outdated
Comment thread src/settings.ts Outdated
Comment thread src/cli.ts Outdated
Comment thread src/utils.ts Outdated
Comment thread src/utils.ts Outdated
Comment thread src/index.ts Outdated
Comment thread src/filters.ts Outdated
Comment thread src/settings.ts Outdated
Comment thread src/settings.ts Outdated
Comment thread src/utils.ts Outdated
Comment thread src/filters.ts Outdated
Comment thread src/cli.ts Outdated
Comment thread src/settings.ts Outdated
Comment thread src/index.ts Outdated
Comment thread src/utils.ts Outdated
@rugpanov

rugpanov commented May 19, 2022

Copy link
Copy Markdown
Author

@joebowbeer Is there any sense to fix these code style issues if we're not going to merge branches?

I believe I did many cool features in these MR. After all, it would be cool to merge it somehow to the main package.

@joebowbeer

Copy link
Copy Markdown
Owner

@rugpanov please excuse the Codacy comments. I'm experimenting with code coverage tools.

I haven't ruled out your significant enhancements, but I still haven't found time to test them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants