Repository navigation
fix(mobile): native header buttons run their current handler - #56
Merged
Merged
Conversation
iOS header items are re-sent to the navigator only when what they show changes. A button whose handler changed without a visible change kept the handler from an older render. On the merge sheet, toggling a second pull request kept Continue's look, so Continue checked only the first one. Presses now go through a ref that holds the current handlers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
vouch:trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS,
NativeHeaderToolbarre-sends header items to the navigator only when what they show changes. That avoids asetOptionsloop, because functions are compared by their source text. As a result, a button whose handler changed without a visible change kept the handler from an older render. On the quick action merge sheet, toggling a second pull request left Continue looking the same, so Continue checked only the first pull request.Fix: each native item now calls a stable wrapper. The wrapper looks up the current handler in a ref, which is updated after each render. Wrapper source text stays the same, so this adds no extra
setOptionscalls. The new test fails before the change: it ran the first selection's handler.This may not explain the reported "Continue does nothing". I could not reproduce that, because the pull requests were merged by hand before I could.
Checks:
vp run check:changedpasses format, lint, typecheck, and the toolbar tests. knip reports three unused files that this PR does not touch.Done by Claude Opus 5.5 in Claude Code (T3 Code).