Repository navigation
feat(clients): navigate threads with Mod+Alt+Arrow - #43
Merged
Merged
Conversation
- Replace default thread navigation shortcuts with Mod+Alt+Arrow keys - Migrate prior defaults once while preserving custom bindings
github-actions
Bot
added
vouch:trusted
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 57 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Thread navigation used
Mod+Shift+[andMod+Shift+], which are less discoverable and awkward across keyboard layouts. Users need consistent shortcuts to move between threads.Change
Use
Mod+Alt+ArrowUpandMod+Alt+ArrowDownfor previous and next thread across clients. On startup, migrate the old defaults once, preserve customized bindings, and keep an old binding if its replacement shortcut is already taken. Add coverage for shortcut resolution and migration behavior.Scope and approval
This is a focused shortcut change using the existing thread navigation commands and keybinding system. No new workflow or capability is added.
Verification
Added server tests for one-time migration, customized bindings, and shortcut conflicts. Added web tests for shortcut resolution on macOS, Windows, and Linux. Tests were not run.