Repository navigation
fix(web): splash textarea starts small + grows to cap - #6
Merged
Merged
Conversation
The previous attempt set min-h/max-h via [&_textarea]: child-selector classes on the wrapper span, but they lost a CSS specificity battle against the Textarea component's own inner classes (`min-h-17.5`, etc.) — net effect was a textarea stuck at the min, with content overflowing into a scrollbar instead of growing. Move height controls to inline `style` (passes through mergeProps to the inner textarea, beats every stylesheet rule). Also drop the `sm:min-h-[184px]` desktop override so the box starts at 140px on all screens. `field-sizing-content` (already on the inner textarea) does the actual auto-grow up to maxHeight, then `overflow-y-auto` scrolls inside past the cap. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move height controls (min-h: 140px, max-h: 40vh) to inline style on the splash composer Textarea so they win CSS specificity vs the inner textarea's own min-h-17.5. Drop the desktop sm: override so the box starts at the same 140px on all screens. field-sizing-content does the auto-grow up to the cap; overflow-y-auto scrolls past it.