Fix release-blocking pack failure: Microsoft.Extensions.AI stable GA - #29
Merged
Merged
Conversation
The v1.10.0 tag's release workflow failed at "dotnet pack" (NU5104): Scrubkit.Extensions.MicrosoftExtensionsAI (and transitively Scrubkit.Extensions.SemanticKernel, Scrubkit.All) depended on Microsoft.Extensions.AI(.Abstractions) 9.0.0-preview.9.24525.1, and a stable release cannot depend on a prerelease package. Move to the 9.5.0 stable line (the earliest GA release, keeping the DI.Abstractions/Logging.Abstractions bump minimal: 9.0.0 -> 9.0.5). The GA API renamed IChatClient.CompleteAsync/CompleteStreamingAsync to GetResponseAsync/GetStreamingResponseAsync (ChatCompletion -> ChatResponse, StreamingChatCompletionUpdate -> ChatResponseUpdate) and dropped the settable ChatMessage.Text in favor of mutating TextContent items in Contents; RedactingChatClient and its tests are updated accordingly. Verified: full solution build, all 484 tests, and `dotnet pack -c Release` all succeed (previously failed on pack).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.10.0 tag's release workflow failed at "dotnet pack" (NU5104): Scrubkit.Extensions.MicrosoftExtensionsAI (and transitively Scrubkit.Extensions.SemanticKernel, Scrubkit.All) depended on Microsoft.Extensions.AI(.Abstractions) 9.0.0-preview.9.24525.1, and a stable release cannot depend on a prerelease package.
Move to the 9.5.0 stable line (the earliest GA release, keeping the DI.Abstractions/Logging.Abstractions bump minimal: 9.0.0 -> 9.0.5). The GA API renamed IChatClient.CompleteAsync/CompleteStreamingAsync to GetResponseAsync/GetStreamingResponseAsync (ChatCompletion -> ChatResponse, StreamingChatCompletionUpdate -> ChatResponseUpdate) and dropped the settable ChatMessage.Text in favor of mutating TextContent items in Contents; RedactingChatClient and its tests are updated accordingly.
Verified: full solution build, all 484 tests, and
dotnet pack -c Releaseall succeed (previously failed on pack).What & why
Briefly describe the change and the motivation. Link any related issue (e.g.
Fixes #123).Checklist
dotnet build Scrubkit.slnx -c Releasepasses (no warnings — Release is warnaserror)dotnet test Scrubkit.slnx -c Releasepasses; new code is coveredScrubkit.Abstractions)Directory.Packages.propsand committed refreshedpackages.lock.jsonCHANGELOG.mdunder[Unreleased]if user-facing