RTDEB-61940 - Support debug mode and improve logging - #293
Merged
Conversation
mnsboev
approved these changes
Aug 13, 2025
avishayh
reviewed
Aug 13, 2025
| } | ||
| static setCliEnv() { | ||
| var _a, _b, _c, _d, _e; | ||
| if (core.isDebug()) { |
There was a problem hiding this comment.
i think we can add another check that JFROG_CLI_LOG_LEVEL was not already configured by the user.
if for some case user put JFROG_CLI_LOG_LEVEL=ERROR in his environment we need to respect that
Contributor
Author
There was a problem hiding this comment.
We're using the exportVariableIfNotSet() that does that. We don't override user explicit environment variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm run formatfor formatting the code before submitting the pull request.