Skip to content

When moving commits up/down and the selection leaves the view, scroll to make it visible again#5247

Merged
stefanhaller merged 1 commit intomasterfrom
scroll-commit-into-view-after-move-up-down
Jan 28, 2026
Merged

When moving commits up/down and the selection leaves the view, scroll to make it visible again#5247
stefanhaller merged 1 commit intomasterfrom
scroll-commit-into-view-after-move-up-down

Conversation

@stefanhaller
Copy link
Copy Markdown
Collaborator

This used to work before 0.58, but broke with efd4298 (#5134).

Fixes #5244.

… to make it visible again

This used to work before 0.58, but broke with efd4298
(#5134).
@stefanhaller stefanhaller added the bug Something isn't working label Jan 28, 2026
@stefanhaller stefanhaller merged commit 4c9cc1a into master Jan 28, 2026
14 checks passed
@stefanhaller stefanhaller deleted the scroll-commit-into-view-after-move-up-down branch January 28, 2026 19:47
@codacy-production
Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for ce202a51 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (ce202a5) Report Missing Report Missing Report Missing
Head commit (02997d3) 59611 51946 87.14%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#5247) 4 4 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Feb 15, 2026
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [jesseduffield/lazygit](https://github.com/jesseduffield/lazygit) | minor | `v0.58.1` → `v0.59.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>jesseduffield/lazygit (jesseduffield/lazygit)</summary>

### [`v0.59.0`](https://github.com/jesseduffield/lazygit/releases/tag/v0.59.0)

[Compare Source](jesseduffield/lazygit@v0.58.1...v0.59.0)

<!-- Release notes generated using configuration in .github/release.yml at v0.59.0 -->

#### What's Changed

##### Enhancements 🔥

- Have "Find base commit for fixup" ignore fixup commits for the found base commit by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5210](jesseduffield/lazygit#5210)
- Exclude commit trailers from line wrapping by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5230](jesseduffield/lazygit#5230)
- Limit popup panel widths to a maximum width by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5231](jesseduffield/lazygit#5231)
- Support using the selected commit's message in a fixup by [@&#8203;jesseduffield](https://github.com/jesseduffield) in [#&#8203;5233](jesseduffield/lazygit#5233)
- Fix gitignore path collisions by [@&#8203;DawidPietrykowski](https://github.com/DawidPietrykowski) in [#&#8203;5245](jesseduffield/lazygit#5245)

##### Fixes 🔧

- Don't log the "git rev-list" call when marking bisect commits by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5236](jesseduffield/lazygit#5236)
- Fix opening a menu when a previous menu was scrolled down by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5238](jesseduffield/lazygit#5238)
- When moving commits up/down and the selection leaves the view, scroll to make it visible again by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5247](jesseduffield/lazygit#5247)
- Fix rendering of CRLF sequence ('\r\n') by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5237](jesseduffield/lazygit#5237)
- Fix rendering of the Reflog panel when using up/down to scroll it by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5248](jesseduffield/lazygit#5248)
- Add Nushell support for nvim-remote preset by [@&#8203;baiyeidk](https://github.com/baiyeidk) in [#&#8203;5250](jesseduffield/lazygit#5250)

##### Maintenance ⚙️

- Update devcontainer `VARIANT` to `1-trixie` by [@&#8203;mricherzhagen](https://github.com/mricherzhagen) in [#&#8203;5204](jesseduffield/lazygit#5204)
- chore: Update outdated GitHub Actions versions by [@&#8203;pgoslatara](https://github.com/pgoslatara) in [#&#8203;5220](jesseduffield/lazygit#5220)
- Disable the automatic, scheduled release by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5272](jesseduffield/lazygit#5272)
- Auto-update cheatsheets after updating translation by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5275](jesseduffield/lazygit#5275)

##### Docs 📖

- Update README to add GitArbor TUI as an alternative by [@&#8203;cadamsdev](https://github.com/cadamsdev) in [#&#8203;5257](jesseduffield/lazygit#5257)
- Update docs and schema for release by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5276](jesseduffield/lazygit#5276)

##### I18n 🌎

- Update translations from Crowdin by [@&#8203;stefanhaller](https://github.com/stefanhaller) in [#&#8203;5274](jesseduffield/lazygit#5274)

#### New Contributors

- [@&#8203;pgoslatara](https://github.com/pgoslatara) made their first contribution in [#&#8203;5220](jesseduffield/lazygit#5220)
- [@&#8203;cadamsdev](https://github.com/cadamsdev) made their first contribution in [#&#8203;5257](jesseduffield/lazygit#5257)
- [@&#8203;baiyeidk](https://github.com/baiyeidk) made their first contribution in [#&#8203;5250](jesseduffield/lazygit#5250)

**Full Changelog**: <jesseduffield/lazygit@v0.58.1...v0.59.0>

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0Mi45Ni4yIiwidXBkYXRlZEluVmVyIjoiNDIuOTYuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90IiwiYXV0b21hdGlvbjpib3QtYXV0aG9yZWQiLCJkZXBlbmRlbmN5LXR5cGU6Om1pbm9yIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

moveDownCommit and moveUpCommit should apply scrollOffMargin

1 participant