fix strips emoji fixing UI#4247
Closed
X1Vi wants to merge 1 commit intojesseduffield:masterfrom
Closed
Conversation
Now the emoji is not visible in the commits panel. However a commit message is not changed it remains as is. This fixes the UI issue where it was distrubing the diff panel Closes jesseduffield#3811 fixed linting issues
Collaborator
|
I don't think this is an appropriate fix; I do want to see emojis in the commits panel. We should rather fix the printing of the emojis so that it doesn't have these alignment issues. Now this may be tricky, depending on the terminal emulator being used, but I do think we should try to support Mode 2027 (see here) and then hope that more terminal emulators catch up to support it. |
Collaborator
|
This is fixed properly on master now (see #5116); closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now the emoji is not visible in the commits panel. However a commit message is not changed it remains as is. This fixes the UI issue where it was distrubing the diff panel
Closes #3811
go generate ./...)