Skip to content

Pretty print test duration artifact#31

Merged
jerry-git merged 4 commits into
jerry-git:masterfrom
vpipkt:feat/duration-json-pretty
Nov 9, 2021
Merged

Pretty print test duration artifact#31
jerry-git merged 4 commits into
jerry-git:masterfrom
vpipkt:feat/duration-json-pretty

Conversation

@vpipkt

@vpipkt vpipkt commented Aug 11, 2021

Copy link
Copy Markdown
Contributor

This will enable cleaner comparisons for duration artifacts stored in VCS.

@vpipkt

vpipkt commented Oct 12, 2021

Copy link
Copy Markdown
Contributor Author

Can we get a maintainer review of this PR? Any feedback on this?

@jerry-git jerry-git self-requested a review October 12, 2021 17:01
@jerry-git

Copy link
Copy Markdown
Owner

Sorry, seems that I haven't seen this before. Hmm, the CI (GHA) doesn't run for some reason 🤔

Comment thread tests/test_plugin.py Outdated
@vpipkt

vpipkt commented Oct 15, 2021

Copy link
Copy Markdown
Contributor Author

@jerry-git now we have the workflow awaiting approval, b/c this is the first PR I've opened on the repo. We appreciate your attention to this one!

@vpipkt

vpipkt commented Oct 18, 2021

Copy link
Copy Markdown
Contributor Author

Any ideas what is going wrong with the CI build? It is failing installing poetry... 😞

@jerry-git

Copy link
Copy Markdown
Owner

I updated the install-poetry action, pull the latest changes from master please 🙂

@vpipkt

vpipkt commented Oct 19, 2021

Copy link
Copy Markdown
Contributor Author

hmm now the workflow is awaiting approval again. @jerry-git thanks for dealing with all the noise here.

@vpipkt

vpipkt commented Oct 22, 2021

Copy link
Copy Markdown
Contributor Author

Looks like this one is ready to go

@jerry-git jerry-git left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@jerry-git jerry-git merged commit 8b5a89e into jerry-git:master Nov 9, 2021
@jerry-git

Copy link
Copy Markdown
Owner

Available in 0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants