Skip to content

Add API for metric aggregation type#275

Draft
akash-manna-sky wants to merge 9 commits into
jenkinsci:mainfrom
akash-manna-sky:issue-270
Draft

Add API for metric aggregation type#275
akash-manna-sky wants to merge 9 commits into
jenkinsci:mainfrom
akash-manna-sky:issue-270

Conversation

@akash-manna-sky

Copy link
Copy Markdown
Contributor

Add API for metric aggregation type

Fixes #270

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

Comment thread src/main/java/edu/hm/hafner/coverage/MetricAggregation.java Fixed
@akash-manna-sky akash-manna-sky marked this pull request as ready for review March 2, 2026 17:03
@uhafner uhafner added the feature New features label Mar 3, 2026
@akash-manna-sky

Copy link
Copy Markdown
Contributor Author

Please review the changes. I tried to add API for matric aggregation type as you described in the issue description. There are a few SpotBugs issues, I tried to fix but can't. I used @SuppressFBWarnings but still SpotBugs are complaining and also I am facing a problem in Unicode transformations handling in MetricAggregation.java at L98 & L99. Can you please help me? @uhafner

@github-actions github-actions Bot requested a review from uhafner March 9, 2026 14:31
@akash-manna-sky

Copy link
Copy Markdown
Contributor Author

Hi, can we work on this PR? @uhafner

@uhafner uhafner marked this pull request as draft March 31, 2026 20:53
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

☀️   Quality Monitor

Tests

   JUnit   Unit Tests: ✅ successful — 445 passed $\color{green}{\textsf{(+54)}}$
   ⛔   Architecture Tests: ✅ successful — 10 passed $\textsf{(±0)}$

Coverage for New Code

   〰️   Line Coverage: 97.14% — 2 missed lines
   ➰   Branch Coverage: 93.48% — 3 missed branches
   PIT   Mutation Coverage: 95.35% — 2 survived mutations
   💪   Test Strength: 100.00% — perfect 🎉

Coverage for Whole Project

   〰️   Line Coverage: 95.81% $\color{green}{\textsf{(+0.03)}}$ — 133 missed lines
   ➰   Branch Coverage: 91.45% $\color{green}{\textsf{(+0.08)}}$ — 116 missed branches
   PIT   Mutation Coverage: 89.60% $\color{green}{\textsf{(+0.16)}}$ — 162 survived mutations
   💪   Test Strength: 92.63% $\color{green}{\textsf{(+0.14)}}$ — 111 survived mutations in tested code

Style

   CheckStyle   CheckStyle: No warnings $\textsf{(±0)}$
   PMD   PMD: No warnings $\textsf{(±0)}$
   ☕   Java Compiler: No warnings $\textsf{(±0)}$

Bugs

   SpotBugs   SpotBugs: No bugs $\textsf{(±0)}$
   🐛   Error Prone: No bugs $\textsf{(±0)}$

API Problems

   🚫   Revapi: 5 warnings $\color{green}{\textsf{(+5)}}$ — low: 5

Vulnerabilities

   🛡️   OWASP Dependency Check: No vulnerabilities $\textsf{(±0)}$

Software Metrics

   🌀   Cyclomatic Complexity: 973 (total)
   💭   Cognitive Complexity: 757 (total)
   ➿   N-Path Complexity: 1545 (total)
   📏   Lines of Code: 9864 (total)
   📝   Non Commenting Source Statements: 3929 (total)
   🔗   Class Cohesion: 54.55% (maximum)
   ⚖️   Weight of Class: 100.00% (maximum)

📌 Reference Results

Delta reports computed against the reference results of 29bfd53 in workflow run 27209365117.

🚦 Quality Gates

Overall Status: ✅ SUCCESS

✅ Passed Gates

  • ✅ Overall Tests Success Rate: 100.00 >= 100.00
  • ✅ Line Coverage in New Code: 97.14 >= 90.00
  • ✅ Branch Coverage in New Code: 93.48 >= 90.00
  • ✅ Mutation Coverage in New Code: 95.35 >= 90.00
  • ✅ Potential Bugs in Whole Project: 0.00 <= 0.00
  • ✅ Style Violation in Whole Project: 0.00 <= 0.00

Created by Quality Monitor v4.15.0 (#82d77af). More details are shown in the GitHub Checks Result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add API for metric aggregation type

3 participants