You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR updates the matrix-auth plugin JCasC documentation to reflect the syntax changes introduced in matrix-auth 3.2+.
The previous examples used the deprecated pre-3.2 format.
I added an updated example using the new entries: structure and noted that the old format is deprecated but still works when deprecated: warn is enabled.
[ x] Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
[ x] Ensure that the pull request title represents the desired changelog entry
[ x] Please describe what you did
[ x] Link to relevant issues in GitHub or in Jenkins JIRA
[ x] Link to relevant pull requests, esp. upstream and downstream changes
Did you provide a test-case? That demonstrates feature works or fixes the issue.
The documentation does use the 3.2+ format already???
The docs mention 3.2+, but the example shown is still using the older pre-3.2 syntax.
My change updates the example to the actual 3.2+ entries: format used by matrix-auth now, so the documentation matches the current schema.
The documentation does use the 3.2+ format already???
The docs mention 3.2+, but the example shown is still using the older pre-3.2 syntax. My change updates the example to the actual 3.2+ entries: format used by matrix-auth now, so the documentation matches the current schema.
Your change only adds:
Note: Starting from matrix-auth 3.2, the older grantedPermissions: JCasC syntax is deprecated.
The examples below already use the new entries: format, which should be used going forward.
You have a conflict with master probably got an old version locally?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the matrix-auth plugin JCasC documentation to reflect the syntax changes introduced in matrix-auth 3.2+.
The previous examples used the deprecated pre-3.2 format.
I added an updated example using the new entries: structure and noted that the old format is deprecated but still works when deprecated: warn is enabled.