docs(rust): combine clap migration guidance - #1217
Conversation
Co-authored-by: jdx <jdx@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 4 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe PR moves clap compatibility guidance into ChangesClap migration documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR reorganizes Rust migration documentation and preserves the old compatibility-page link through a redirect; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Instruction counts
No instruction-count regression above 6%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes. Shadow comparisonParsing
|
Move clap-specific caveats into the migration compatibility table and document Unix/Windows argv encoding on args and flags. Co-authored-by: jdx <jdx@users.noreply.github.com>
Folds clap compatibility into the migration guide and moves leftover “Current limitations” off
/rust/.Changes
/rust/clap-compatibilityas a redirect stub to that section so old links still work./rust/: clap-specific bullets already live in Compatibility gaps; addvalue_optionalthere; documentPathBuf/OsString/Stringargv encoding on Args and flags.Notes
/go/still has its own Current limitations section; this change is Rust-only.Summary by CodeRabbit