Repository navigation
docs: explain project adoption - #35
Conversation
📝 WalkthroughWalkthroughThe PR adds an adoption guide, configuration guidance, CI workflow examples, rollout validation criteria, and links to the new documentation from the README and guide navigation. Changestak Documentation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR adds an adoption guide covering benchmark selection, main-branch recording, pull-request gating, credential separation, and release backfills.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (3): Last reviewed commit: "docs: clarify integration examples" | Re-trigger Greptile |
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/guide/adopting.md`:
- Around line 225-231: Update the backfill guidance around the `tak backfill`
example to explicitly require a full repository clone or locally fetched release
tags before running it. Add a verification step that confirms at least one
release was recorded before executing `tak push`, and preserve the existing
backfill command and workflow.
- Around line 238-241: Update the guidance for the backfill workflow to require
executing downloaded release binaries in an ephemeral isolated runner or
container without credentials and with restricted network egress, then pass only
the generated notes artifact to the publishing job. If this isolation cannot be
guaranteed, explicitly limit the guidance to trusted release assets.
- Around line 93-95: Update the guide’s workflow description and the
corresponding sections around the push trigger to match actual behavior: since
the workflow records only the event tip for each push, narrow the claim from
every main-branch commit to each push tip. Apply the same wording adjustment to
the referenced sections, unless the workflow is changed to process every SHA in
the push range.
- Around line 163-178: Update the workflow’s compare preparation around the
compare job and checkout step so private-repository access remains available for
the merge-base and notes fetches without exposing credentials to PR-controlled
measurement code. Move those fetch and comparison operations into a trusted
preparation job, or scope a short-lived read-only credential exclusively to the
post-measurement fetch and tak compare steps while keeping credentials
unavailable during PR code execution.
- Around line 110-114: Update the GitHub Actions examples in adopting.md to
replace every mutable actions/checkout@v7 and jdx/mise-action@v4 reference with
its full immutable commit SHA, including both occurrences in each workflow
section. Preserve the corresponding release version as an inline comment for
maintainers and dependency tooling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: eb6fcda8-9abe-4f8d-867d-6d0aea82fc68
📒 Files selected for processing (5)
README.mddocs/.vitepress/config.mtsdocs/guide/adopting.mddocs/guide/configuration.mddocs/guide/getting-started.md
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
## 🤖 New release * `asset-picker`: 0.0.1 -> 0.0.2 (✓ API compatible changes) * `tak-cli`: 0.0.5 -> 0.0.6 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `asset-picker` <blockquote> ## [0.0.2](https://github.com/jdx/tak/compare/0.0.1..0.0.2) - 2026-08-02 ### 📚 Documentation - replace experimental disclaimers with pre-v1 warnings by [@jdx](https://github.com/jdx) in [#34](#34) <!-- generated by git-cliff --> </blockquote> ## `tak-cli` <blockquote> ## [0.0.6](https://github.com/jdx/tak/compare/0.0.5..0.0.6) - 2026-08-02 ### 🚀 Features - make the runner class a setting by [@jdx](https://github.com/jdx) in [#25](#25) ### 📚 Documentation - add the tak documentation site by [@jdx](https://github.com/jdx) in [#28](#28) - replace experimental disclaimers with pre-v1 warnings by [@jdx](https://github.com/jdx) in [#34](#34) - explain project adoption by [@jdx](https://github.com/jdx) in [#35](#35) - replace experiment framing by [@jdx](https://github.com/jdx) in [#37](#37) ### 🔍 Other Changes - lock communique, so a release stops needing a human by [@jdx](https://github.com/jdx) in [#26](#26) <!-- generated by git-cliff --> </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Version and changelog-only changes; no application logic modified in this PR. > > **Overview** > **Automated release** via release-plz: bumps **`tak-cli`** from `0.0.5` to **`0.0.6`** and workspace crate **`asset-picker`** from `0.0.1` to **`0.0.2`**, with matching updates in **`Cargo.lock`** and the path dependency version in root **`Cargo.toml`**. > > Adds git-cliff **changelog** entries for **0.0.6** (root) and **asset-picker 0.0.2**, documenting already-merged work— notably **runner class as a setting**, docs site and pre-v1 messaging, and **communique** lockfile changes—without introducing new runtime code in this diff. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit be8b102. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Summary
Impact
This gives pre-v1 adopters a complete local-to-CI path while keeping the storage details in the existing git-notes guide. The workflow snippets are deliberately smaller than the production examples and link to mise and aube for hardened implementations.
Validation
mise run ciAI-generated by Codex.
Note
Low Risk
Documentation-only changes with no runtime or configuration behavior changes.
Overview
Adds an adoption guide (
docs/guide/adopting.md) that walks through the full local-to-CI loop: choosing hermetic benchmarks, declaringtak.toml, recording main-branch tips into git notes, gating PRs on merge-base comparisons (with credential stripping before untrusted code runs), optional release backfill, and a rollout checklist. It links to mise and aube as reference implementations.The configuration guide gains previously undocumented
[gate],[env]deny/allow, and[report].creditsections, including CLI/env overrides and precedence.Navigation is wired from the README, VitePress sidebar, and getting-started “next steps” to the new guide.
Reviewed by Cursor Bugbot for commit 07955e7. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit