Conversation
export_set guarded the empty case with `if not dataset.dict` but a zero-width dataset (rows present, no columns; dict == [[]]) is truthy, so it fell through to get_col(0)/column_widths[0] and raised IndexError. Such a dataset is valid and round-trips through JSON as '[[]]'; every other text format degrades gracefully (csv -> '\r\n', json -> '[[]]', html/latex -> empty table). Also return '' when the dataset has no columns.
This was referenced Jul 28, 2026
Member
|
You've opened many PRs across these repos two weeks ago, and then closed them with no comment: python-humanize/humanize#352 Please could you explain why? Also hundreds in other repos:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Exporting a zero-width dataset (rows present, no columns) to rst raises
IndexError.export_setguards the empty case withif not dataset.dict, but a zero-width dataset hasdict == [[]]which is truthy, so it falls through toget_col(0)/column_widths[0]and indexes an empty row.Such a dataset is valid:
[[]]is valid JSON that imports cleanly (import_setsets.dictdirectly), and every other text format degrades gracefully (csv/tsv give a blank line, json gives[[]], html/latex give an empty table). Only rst crashes. This also returns''when the dataset has no columns.