avoid exponential backtracking for repeated * in glob patterns - #156
Open
jmestwa-coder wants to merge 1 commit into
Open
jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
Author
|
gentle ping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed translate_core maps each single * to [^/]* and just concatenates them, so a pattern with several * in one segment like aaa.txt becomes adjacent [^/]* groups that backtrack exponentially against a long non-matching name. Through Path.glob a 10-star pattern on a 40-char entry takes about 16s, doubling per added pair of stars. Commit each interior segment star with an atomic group so matching stays linear. This is a different case from the consecutive ** collapse.