Draft: Android CI production build and Play Store auto-submission#3391
Closed
Draft: Android CI production build and Play Store auto-submission#3391
Conversation
* android build conf changes * fix shellcheck warnings android fix audio permission handling android fix androidextras include android remove redundant jdk install add ANDROID_NDK_ROOT comment fix for clang-format style check android add all ABI support android: remove redundant minSdkVersion clang-format fixes android: fix manifest xml, remove old boilerplate add ANDROID_SDK_ROOT shellcheck fix android fix assignments in pro file fix typo
878cc57 to
12631a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Revival of #2909
The primary goal of the patch was to enable Google Play Store automated uploads as part of the GitHub build process.
CHANGELOG: DO NOT MERGE
Context: Fixes an issue?
The patch not only adopts the new action (r0adkll/upload-google-play@v1) but changes dependencies:
COMMANDLINETOOLS_VERSIONANDROID_NDK_VERSIONANDROID_PLATFORMANDROID_BUILD_TOOLSAQTINSTALL_VERSIONQT_VERSIONAs a side effect, it enables the Jamulus.pro to build on Windows by removing the Linux dependency (or at least side-stepping it).
Code changes are a side effect of the move to Qt6 (but I think probably work in Qt5.15.2, too, so could be trialled).
Does this change need documentation? What needs to be documented and how?
We should add documentation about the build process somewhere but that's not part of this ticket. Unless it already exists and needs changing.
Status of this Pull Request
Proof of concept (not to be merged soon).
What is missing until this pull request can be merged?
Checklist