Repository navigation
fix(fork): Lathe sends no usage telemetry unless opted in - #64
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lathe inherited upstream's product telemetry unchanged: the server posted usage events to T3 Tools' PostHog project, with T3's project key, on by default, and the welcome screen and Settings told users "T3 Code collects anonymous usage data" under T3's privacy policy. A fork should not report its users to upstream's analytics by default, and the copy read as if Lathe's maker collected the data.
Change
FORK_IDENTITY.telemetryEnabledByDefaultisfalse, andAnalyticsServicereads it as the default forT3CODE_TELEMETRY_ENABLED(one import plus a one-line swap in the upstream file). Setting the variable totruestill opts in.docs/user/telemetry.mddescribes the opt-in instead of the opt-out.Verification
T3CODE_TELEMETRY_ENABLEDunset, nothing is sent. It failed before the change (one batch posted) and passes after; the other four telemetry tests still pass.forkIdentity.test.tspasses; shared, server and web typecheck; lint and format pass on the changed files.