Skip to content

Fix code formatting to comply with Orleans coding guidelines - #9

Merged
jaironalves merged 2 commits into
feature/redis-durablejobsfrom
copilot/implement-unresolved-review-comments
Dec 6, 2025
Merged

jaironalves merged 2 commits into
feature/redis-durablejobsfrom
copilot/implement-unresolved-review-comments

Conversation

Copilot AI commented Dec 6, 2025 •

Copy link
Copy Markdown

Addresses unresolved review comments from dotnet#9823 regarding code formatting violations in the Redis DurableJobs implementation.

Changes

RedisJobShard.cs

  • Add braces on new lines for foreach loops (lines 237, 245)
  • Add braces on new line for catch (OperationCanceledException) block (line 257)

Before:

foreach (var op in batchOperations) op.CompletionSource.TrySetResult();

After:

foreach (var op in batchOperations)
{
    op.CompletionSource.TrySetResult();
}

RedisJobShardManagerTestFixture.cs

  • No changes required; already using is null/is not null and null-forgiving operator correctly

All changes align with Orleans guideline: "Insert a newline before the opening curly brace of any code block."

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • 4m6vsblobprodcus384.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build src/Redis/Orleans.DurableJobs.Redis/Orleans.DurableJobs.Redis.csproj --configuration Release (dns block)
  • cflvsblobprodcus383.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build src/Redis/Orleans.DurableJobs.Redis/Orleans.DurableJobs.Redis.csproj --configuration Release (dns block)
  • ckzvsblobprodcus347.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build src/Redis/Orleans.DurableJobs.Redis/Orleans.DurableJobs.Redis.csproj --configuration Release (dns block)
  • dnceng.pkgs.visualstudio.com
    • Triggering command: /usr/bin/dotnet dotnet build src/Redis/Orleans.DurableJobs.Redis/Orleans.DurableJobs.Redis.csproj --configuration Release (dns block)
  • frdvsblobprodcus327.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build src/Redis/Orleans.DurableJobs.Redis/Orleans.DurableJobs.Redis.csproj --configuration Release (dns block)
  • k0ivsblobprodcus356.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build src/Redis/Orleans.DurableJobs.Redis/Orleans.DurableJobs.Redis.csproj --configuration Release (dns block)
  • m6xvsblobprodcus342.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build src/Redis/Orleans.DurableJobs.Redis/Orleans.DurableJobs.Redis.csproj --configuration Release (dns block)
  • p2ovsblobprodcus312.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build src/Redis/Orleans.DurableJobs.Redis/Orleans.DurableJobs.Redis.csproj --configuration Release (dns block)
  • pc2vsblobprodcus360.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build src/Redis/Orleans.DurableJobs.Redis/Orleans.DurableJobs.Redis.csproj --configuration Release (dns block)
  • rcxvsblobprodcus328.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build src/Redis/Orleans.DurableJobs.Redis/Orleans.DurableJobs.Redis.csproj --configuration Release (dns block)
  • se1vsblobprodcus349.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build src/Redis/Orleans.DurableJobs.Redis/Orleans.DurableJobs.Redis.csproj --configuration Release (dns block)
  • yttvsblobprodcus357.vsblob.vsassets.io
    • Triggering command: /usr/bin/dotnet dotnet build src/Redis/Orleans.DurableJobs.Redis/Orleans.DurableJobs.Redis.csproj --configuration Release (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

dotnet#9823 Implemente as sugestoes dos comentarios que nao estao como resolved


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Dec 6, 2025
- Add braces on new lines for foreach loops in RedisJobShard.cs
- Add braces on new line for catch block in RedisJobShard.cs
- Addresses unresolved PR review comments about code formatting

Co-authored-by: jaironalves <29267813+jaironalves@users.noreply.github.com>
@jaironalves
jaironalves marked this pull request as ready for review December 6, 2025 18:37
Copilot AI changed the title [WIP] Address unresolved review comments in pull request 9823 Fix code formatting to comply with Orleans coding guidelines Dec 6, 2025
Copilot AI requested a review from jaironalves December 6, 2025 18:38
@jaironalves
jaironalves merged commit 2013565 into feature/redis-durablejobs Dec 6, 2025
@jaironalves
jaironalves deleted the copilot/implement-unresolved-review-comments branch December 6, 2025 18:38
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants