Repository navigation
common : store the tokens after each n-gram in a sorted vector - #6
Closed
jadidbourbaki wants to merge 1 commit into
Closed
jadidbourbaki wants to merge 1 commit into
jadidbourbaki wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #5.
I replaced the inner
std::unordered_mapof the n-gram caches with a vector of (token, count) pairs sorted by token. The inner map sends each token that follows an n-gram to its count. Lookups binary search the vector.common_ngram_cache_partkeeps thefind,emplace, iteration, andsizecalls ofcommon/ngram-cache.cpp, socommon/ngram-cache.cppis unchanged. C++23 hasstd::flat_mapfor a sorted vector with a map interface, but llama.cpp builds as C++17.The drafting logic and the cache file format are unchanged.
Results
The benchmark is running.