common : store the ngram caches in unordered_dense maps - #3
Closed
jadidbourbaki wants to merge 3 commits into
Closed
jadidbourbaki wants to merge 3 commits into
jadidbourbaki wants to merge 3 commits into
Conversation
jadidbourbaki
added this pull request to stack #4
September 26, 2026 14:15
Owner
Author
|
Replaced by #5. |
jadidbourbaki
removed this pull request from stack #4
September 26, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2.
I replaced the nested
std::unordered_maps of the n-gram caches with two flatter structures.ankerl::unordered_dense::map. I vendored unordered_dense v5.0.1 undervendor/ankerland pinned it inscripts/sync_vendor.py.I first made the inner map an
unordered_densemap as well. Memory went up, because anunordered_densemap with one entry takes about 430 bytes. A pair in the sorted vector takes 8 bytes.common/ngram-cache.cpp, the drafting logic, and the cache file format are unchanged.Results
I ran
llama-lookup-statson WikiText-103 test with static caches built from prefixes of WikiText-103 train. Each value is the median of 3 runs on an Apple M4 Pro. A corpus size of 0 means no static cache. #2 is the baseline.The benchmark code and full tables are in ngram-cache-bench.