fix(doubao): preserve image URLs in read output#708
Merged
jackwener merged 3 commits intojackwener:mainfrom Apr 3, 2026
Merged
fix(doubao): preserve image URLs in read output#708jackwener merged 3 commits intojackwener:mainfrom
jackwener merged 3 commits intojackwener:mainfrom
Conversation
MonkeyLeeT
changed the title
MonkeyLeeT
changed the title
jackwener
approved these changes
Apr 3, 2026
Owner
jackwener
left a comment
jackwener
left a comment
There was a problem hiding this comment.
LGTM. Clean refactoring, image extraction logic is solid. Minor suggestion about aligning image selectors with text fallback selectors — not blocking.
Hardcoded image selector only covered the first two text selectors, so images inside class-based message containers would be missed. Generate from the shared selector list for consistency.
Owner
|
Fixed the image selector inconsistency — now derived from Since this is from a fork, I'll merge the fix via a separate commit on main if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readoutputRole/Textoutput shape by appending image lines asImage: <url>Root cause
The browser
doubaoextractor only collected visible text from message content. When Doubao returned an image response, the image DOM nodes were ignored, sodoubao readdropped them entirely.Impact
This makes image-bearing Doubao replies show up in the existing browser
ask/readflow without introducing a new output model.Validation
npx vitest run src/clis/doubao/utils.test.tsnpm run typecheckCloses #675