fix(gemini): match Traditional Chinese 'send' label in composer submit (#1849) - #1967
Merged
jackwener merged 1 commit intoJun 18, 2026
Conversation
jackwener#1849) submitComposerScript scored candidate buttons with /send|发送|submit|提交/i, which only covers Simplified Chinese 发送. On the Traditional Chinese Gemini UI the send button is labeled 傳送訊息, matching none of the alternatives, so it scored 0 and the adapter timed out waiting to click it. Add 傳送 (a substring of 傳送訊息) to submitPattern, plus a unit test on the generated submit script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
opencli gemini asktimes out on the Traditional Chinese Gemini UI — the adapter cannot find/click the send button.Root cause
submitComposerScriptinclis/gemini/utils.jsscores candidate buttons with:This only covers Simplified Chinese 「发送」. On the Traditional Chinese UI the send button is labeled 「傳送訊息」, which matches none of the alternatives, so it scores 0 and the adapter times out. Fixes #1849.
Fix
Add 「傳送」 (a substring of 「傳送訊息」) to
submitPattern. One-line change, no behavior change for existing locales.Test
Added a unit test asserting the generated submit script contains 「傳送」, alongside the existing
.click()/ 「发起新对话」 assertions inclis/gemini/utils.test.js.Verification
npm run build— oknpx vitest run clis/gemini/utils.test.js— 27 passednpm run check:typed-error-lint— no new violationsnpm run check:silent-column-drop— no new violations