refactoring/536_resolve-sonar-findings-of-june-2026#537
Merged
redcatbear merged 4 commits intoJun 2, 2026
Conversation
redcatbear
requested review from
cruzel89 and
kaklakariada
and removed request for
cruzel89
|
redcatbear
commented
Jun 2, 2026
Collaborator
Author
redcatbear
left a comment
redcatbear
left a comment
There was a problem hiding this comment.
@kaklakariada, the review is less work than it looks. Most changes fall into on of these categories:
- String concatenation to text block
- Remove superfluous code (like unthrown exceptions)
- Streams improvements (immutability in collector)
- Resource protection
kaklakariada
approved these changes
Jun 2, 2026
redcatbear
deleted the
refactoring/536_resolve-sonar-findings-of-june-2026
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of Sonar findings that OFT collected over the years with Sonar getting new and more tight rules.
Contributes to #536. I don't think we will be able to do everything in a single PR.