Fix for NotSupportedException if AreaBreak is inside a flex container…

[IBaltaga]

Itext seem to not support PageBreak when rendering to pdf if we put it inside a Div with the display:flex style.
For example:

<div style="display:flex;">
    <p>Hello1</p>
    <div style="page-break-after:always"></div>
    <p>Hello2</p>
</div>

will thrown an exception because it will try to draw the AreaBreak.

Did a hotfix to be able to handle even the AreaBreak when parsing the elements inside the Flex container div.

[vitali-pr]

Hi @IBaltaga , thank you for your contribution!

Would you mind signing the Contributor License Agreement and send back to us? The details are available at https://itextpdf.com/en/how-buy/legal/itext-contributor-license-agreement - it's required in order to merge the PR.

Btw, did you run tests with your changes? Are there any issues in test results?

[IBaltaga]

Yes, this is the result. A lot of them are failing for ITALIAN Culture when probably expecting EN , and others because of missing Ghostscript ITEXT_GS_EXEC that i can't understand how to set

Soon i will provide you the Signed Contributor License Agreement

[IBaltaga]

Hello @vitali-pr, i just send you the signed agreement to the support and cla@apryse.com email.
Let me know after you see the PR

[avlemos]

Yes, this is the result. A lot of them are failing for ITALIAN Culture when probably expecting EN , and others because of missing Ghostscript ITEXT_GS_EXEC that i can't understand how to set

Soon i will provide you the Signed Contributor License Agreement

have you checked these instructions? https://github.com/itext/itext-dotnet/blob/develop/BUILDING.md

[IBaltaga]

Yes, this is the result. A lot of them are failing for ITALIAN Culture when probably expecting EN , and others because of missing Ghostscript ITEXT_GS_EXEC that i can't understand how to set
Soon i will provide you the Signed Contributor License Agreement

have you checked these instructions? https://github.com/itext/itext-dotnet/blob/develop/BUILDING.md

Hello, i checked the instructions and now i only have 37 remaining failing test.
Most of them are failing because of the culture, test methods that check error message exception with a string variable write in english
ex:

or wrong decimal separator also based on the culture
ex:

This is the final result

I think that if you run tests on your computer it will be ok.

[aleksf16]

Hi @IBaltaga , thank you for your contribution! Taking into account your fix, we investigated the problem in more detail and avoided the exception in a slightly different way.

[introfog]

@IBaltaga our fix could be found here e036a28

[IBaltaga]

@introfog as I can see the fix is to avoid throwing exception if we put page-break inside a flex container, but page-break functionality would still not be working as expected. Am i wrong?

[introfog]

@introfog as I can see the fix is to avoid throwing exception if we put page-break inside a flex container, but page-break functionality would still not be working as expected. Am i wrong?

You are right, we have ignored AreaBreak inside flex container for now. In all the rest cases AreaBreak works as expected.