Hide empty filters through configuration#117
Merged
cigolpl merged 2 commits intoitemsapi:masterfrom Jul 29, 2022
Merged
Conversation
cigolpl
requested changes
Jul 29, 2022
Member
cigolpl
left a comment
cigolpl
left a comment
There was a problem hiding this comment.
Overall looks great. One question regarding this arg
src/helpers.js
Outdated
| selected: filters.indexOf(v2[0]) !== -1 | ||
| }; | ||
| }) | ||
| .compact(this) |
Member
There was a problem hiding this comment.
Is this argument in compact necessary here ? The data is flowing form one function to next thanks to chain.
Contributor
Author
There was a problem hiding this comment.
Absolutely right, will update shortly.
Member
|
Thanks! This can be get by new version itemsjs@2.1.20 |
Contributor
|
thanks for adding this feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the second idea in #39. This PR adds the
hide_zero_doc_countconfiguration value on aggregations that if set totruewill exclude filters with 0 results.