Skip to content

Sub-properties are now highlighted when in error#159

Merged
sebbalex merged 3 commits into
masterfrom
fix/87
Jan 19, 2021
Merged

Sub-properties are now highlighted when in error#159
sebbalex merged 3 commits into
masterfrom
fix/87

Conversation

@sebbalex

@sebbalex sebbalex commented Jun 5, 2020

Copy link
Copy Markdown
Member

This will highlight also sub-properties in validation process, this is mostly due to divergent ways to call fields between form and go-validator.

It is not ready for merge since exists a bug in parser/external validator:
italia/publiccode-validator-api#10

Fixes:
#87

@bfabio

bfabio commented Jan 11, 2021

Copy link
Copy Markdown
Member

@sebbalex I think this can go in to fix #87. I created a separate issue for the CI failure (italia/publiccode-parser-orb#5)

@bfabio bfabio marked this pull request as ready for review January 11, 2021 13:15
@sebbalex

Copy link
Copy Markdown
Member Author

@sebbalex I think this can go in to fix #87. I created a separate issue for the CI failure (italia/publiccode-parser-orb#5)

I'm not sure about this, this is the error we got:

Either git or ssh (required by git to clone through SSH) is not installed in the image. Falling back to CircleCI's native git client but the behavior may be different from official git. If this is an issue, please use an image that has official git and ssh installed.

ssh: no key found

First line seems just a warning, a fallback native git client somehow exists. Second line, instead seems blocking, wdyt @bfabio

@bfabio

bfabio commented Jan 11, 2021

Copy link
Copy Markdown
Member

@sebbalex I think both will be solved by having git and openssh-client in the executor image (not 100% sure though)

@vercel

vercel Bot commented Jan 17, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/dip-trasformazione-digitale/publiccode-editor/ixaijy8v3
✅ Preview: https://publiccode-editor-git-fix-87.dip-trasformazione-digitale.vercel.app

@bfabio

bfabio commented Jan 19, 2021

Copy link
Copy Markdown
Member

@sebbalex Fixed italia/publiccode-parser-orb#5, CI passes now.

@sebbalex sebbalex merged commit 81bfa9c into master Jan 19, 2021
@sebbalex sebbalex deleted the fix/87 branch January 19, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Malformed boolean value not detected Adding malformed field to publiccode breaks the editor

2 participants