Editor language detection via query param

[valeriocomo]

Subject of the issue

Bug:

The i18n system should detect the browser's language out of the box and serve the right one, or it can be forced with the lang param like this:

https://publiccode-editor-develop.vercel.app/?lang=fr
https://publiccode-editor-develop.vercel.app/?lang=it
https://publiccode-editor-develop.vercel.app/?lang=en

The webapp doesn't change language due to a lang query param.

Steps to reproduce

Append a lang query param to the URL and reload the application.

Expected behaviour

The webapp have to be localized in the language defined by the query param lang.

Actual behaviour

The web app ignore this param.

[tomootes]

This feature would be very useful for us in The Netherlands as well.

[bfabio]

That should be already baked in and it used to support it (since 17404a9)

As we use i18next-browser-languageDetector, it was actually smarter than just the query string:

• If lang is set in the query string, use that.
  So people can share links in that exact localization.
• Otherwise detect the user's browser's language.
  So it picks the best choice by default with no configuration.
• Have the option to use a subdomain or path, in case a local (as in another member state) installation prefers a certain language. Alternatively, it can be set at build time with FALLBACK_LANGUAGE.
• Fallback to English if there is no better choice

publiccode-editor/src/i18n/index.ts

Lines 32 to 38 in 17404a9

	detection: {
	order: ['querystring', 'navigator', 'htmlTag', 'path', 'subdomain'],
	lookupQuerystring: 'lang',
	lookupCookie: 'lang',
	lookupLocalStorage: 'lang',
	lookupSessionStorage: 'lang',

(See https://github.com/i18next/i18next-browser-languageDetector?tab=readme-ov-file#detector-options)

It got lost somewhere after 4307c74.

[valeriocomo]

Hi everyone. This fix has been provided by the community with PR #411.

Thanks @dammafra for this contribution.