Skip to content

Generic package#3

Merged
Adrian Grucza (apgrucza) merged 7 commits into
masterfrom
generic-package
May 29, 2020
Merged

Generic package#3
Adrian Grucza (apgrucza) merged 7 commits into
masterfrom
generic-package

Conversation

@apgrucza

@apgrucza Adrian Grucza (apgrucza) commented May 28, 2020

Copy link
Copy Markdown

Added the ability to build a generic Lambda package. The Lambda function retrieves its parameters at runtime from the AWS Systems Manager Parameter Store and AWS Secrets Manager. Also added a Lambda package for rotation of the RSA keys.

GitHub does not show the differences in build/build.js very well. I suggest using a different tool to view the changes for this file.

Also added GitHub CI and release workflows for generic packages.

@cuichenli

Copy link
Copy Markdown

My only concern about getting parameters from the parameter store is that the users may need to find another tool/mechanism to store the parameters into the parameter store.

@apgrucza

Copy link
Copy Markdown
Author

I tried using environment variables for parameters but they're not supported for Lambda@Edge.

Most users would already be using a tool such as Terraform or CloudFormation to deploy their CloudFront distribution and Lambda function. But if they are manually deploying these then yes, they will also have to manually deploy the parameters/secrets.

I think generally users would want the parameters/secrets to be owned by Terraform or CloudFront so that their lifecycle is managed automatically, e.g. deleted when the CloudFront distribution is deleted. It also lets them set attributes such as tags and rotation rules in a consistent manner.

@apgrucza Adrian Grucza (apgrucza) merged commit ff883df into master May 29, 2020
@apgrucza Adrian Grucza (apgrucza) deleted the generic-package branch May 29, 2020 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants